[openstreetmap/openstreetmap-website] Add Communities page (#3301)
Andy Allan
notifications at github.com
Thu Oct 27 08:39:11 UTC 2022
> Is that an issue for validation? They should all be valid URLs
The issue is more about maintaining the list of schemes (more likely to need revisions than if it was just http(s)), and what to do with ones we don't want to display (mailto, xmpp), what to do with ones we haven't yet allowed, whether to strip them out, drop the record, emit a warning during parsing etc. If it was just http/https/nil that was expected, then the out-of-course handling would need less careful thought.
> I think this is an OCI bug. One of the `#` should be percent-encoded, and I've opened [osmlab/osm-community-index#592](https://github.com/osmlab/osm-community-index/issues/592) about it.
Thanks. It's worth noting that our two approaches to URL validation (`validate_url` gem, `URI::DEFAULT_PARSER.make_regexp`) behave differently - one accepts the second `#`, one doesn't! So I don't want to imply too much that it's a bug in OCI, rather than just something we need to deal with ourselves.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3301#issuecomment-1293186591
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3301/c1293186591 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221027/62efa809/attachment-0001.htm>
More information about the rails-dev
mailing list