[openstreetmap/openstreetmap-website] Communities - communities (PR #3717)

[Andy Allan]

@gravitystorm commented on this pull request.



> @@ -39,6 +39,7 @@ class ClientApplication < ApplicationRecord
 
   validates :key, :presence => true, :uniqueness => true
   validates :name, :url, :secret, :presence => true
+  # TODO: Consider using UrlValidator from validate_url gem.

Turns out I've considered this before! But I'd forgotten about that. Unfortunately it won't work. `validate_url` requires a list of permitted schemes, but for oauth callbacks any scheme needs to be allowed. See https://github.com/perfectline/validates_url/issues/99

I think this comment can be removed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3717#pullrequestreview-1158019701
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3717/review/1158019701 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221027/5a6bd04f/attachment.htm>