[openstreetmap/openstreetmap-website] Add Communities page (#3301)
Brian DeRocher
notifications at github.com
Mon Sep 12 11:31:08 UTC 2022
@openbrian commented on this pull request.
> @@ -0,0 +1,17 @@
+<% content_for :heading do %>
+ <h1><%= t ".title" %></h1>
+<% end %>
+
+<p class="lead"><%= t ".lede_text" %></p>
+
+<h2><%= t ".local_chapters.title" %></h2>
+<p><%= t ".local_chapters.about_text" %></p>
+<p><%= t ".local_chapters.list_text" %></p>
+<ul>
+ <% @local_chapters.each do |chapter| %>
+ <li><a href="<%= chapter.url %>"><%= t "osm_community_index.communities.#{chapter.id}.name" %></a></li>
Yeah, Brakeman just called me out on this issue on my other PRL. I did a little research on it. Keep in mind the url could start with "javaScript:" or "data:". The solution I did, which satisfied Brakeman, is "https://" + url.slice!(”https://"). I can fetch the error later, on a phone here.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3301#discussion_r968301572
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3301/review/1103928347 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220912/288a0efa/attachment.htm>
More information about the rails-dev
mailing list