[openstreetmap/openstreetmap-website] Microcosms microcosms (PR #3683)

Brian DeRocher notifications at github.com
Wed Sep 14 23:15:06 UTC 2022


Andy, thanks for your detailed review!  This is a response to your opening issues.

* Reducing the PR even further - Please understand I have already cut out membership, events, and RSVP.  Seems like you got through half of them today.
* I agree about the feature flag.  Please highlight a design pattern for that, or suggest how to do that.  There is the option to branch from this branch, and merge everything when it's all ready.
* friendly_id appears to be working correctly.  Here's a sample.  https://microcosms.apis.dev.openstreetmap.org/microcosms/openstreetmap-salt-lake-city
* The only reason we have one organizer at this time is to support access control for edit/update.  When we get proper members, they will have roles, organizer/member/whatever.  So there can be multiple organizers.  For phase 2 we create a new model/table and migrate microcosm.organizer into microcosm_member.user_id.

I'll now address all your other concerns above :)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3683#issuecomment-1247392768
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3683/c1247392768 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220914/2fadbdad/attachment-0001.htm>


More information about the rails-dev mailing list