[openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)
mmd
notifications at github.com
Mon Sep 26 12:47:55 UTC 2022
> But if that's really too scary, I can make a couple of methods in child controller classes that return their model classes.
I also found `The parameter #{controller_name} is required` a bit too extreme. Yes, it's super generic, but might be too fragile going forward (think: translations, maybe) . To be honest, I would completely remove the ElementsApiController, and add around 10 lines to each of three controllers. Perfectly fine for me.
Let's wait what both maintainers think about it, before doing any changes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-1257989748
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3715/c1257989748 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220926/80e2ce09/attachment.htm>
More information about the rails-dev
mailing list