[openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)

[Anton Khorev]

> I also found The parameter #{controller_name} is required a bit too extreme. Yes, it's super generic, but might be too fragile going forward (think: translations, maybe)

How do you think the translation string would look like? I think it would be about as extreme. And again, I can do abstract method returning the message.

> I would completely remove the ElementsApiController

Why not remove ApiController too?

> and add around 10 lines to each of three controllers.

I'd remove around 80 lines from each.

I already managed to sneak in an abstract class removing triple copy-paste, although it was in javascript.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-1258047784
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3715/c1258047784 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220926/bbeb17a4/attachment.htm>