[openstreetmap/openstreetmap-website] Avoid using partial rendering in /map.json (PR #4141)

Stillhart notifications at github.com
Fri Aug 11 13:38:59 UTC 2023


Interesting. Just had a brief look into cgimap. Kinda sad that the openstreetmap mirror is not up-to-date, but at least here is a link to the actual project :-)

General question, is there a reason that cgimap is not included in the docker-compose of openstreetmap-website in some way? I would assume it's because a multi-repo setup is not fun to work with.

Second question: Now that this is usually served with cgimap, is there a reason not to accept my merge request? It still enhances the development experience. Also I would like to further improve the /map.json endpoint, since it seems to be implemented rather unoptimized. I can see tons of n+1 queries which probably could be fixed with some simple joins and includes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4141#issuecomment-1674809970
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4141/c1674809970 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230811/39463be1/attachment.htm>


More information about the rails-dev mailing list