[openstreetmap/openstreetmap-website] Create a base user resources controller class (PR #4197)

[Anton Khorev]

For things that have username in their path like `https://www.openstreetmap.org/user/<username>/diary`. Later also for things with user id in their path.

The goal is to make `ApplicationController` smaller. Code dealing with resolving user names/ids will go into the base class. Adding anything to `ApplicationController` will cause Rubocop to complain.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4197

-- Commit Summary --

  * Create base controller class for user resources
  * Make notes controller inherit from user resources controller
  * Lookup user before action in user's notes list

-- File Changes --

    M app/controllers/application_controller.rb (18)
    M app/controllers/changesets_controller.rb (2)
    M app/controllers/confirmations_controller.rb (2)
    M app/controllers/diary_entries_controller.rb (2)
    M app/controllers/friendships_controller.rb (2)
    M app/controllers/messages_controller.rb (2)
    M app/controllers/notes_controller.rb (30)
    M app/controllers/traces_controller.rb (2)
    M app/controllers/user_blocks_controller.rb (2)
    A app/controllers/user_resources_controller.rb (23)
    M app/controllers/user_roles_controller.rb (2)
    M app/controllers/users_controller.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4197.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4197.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4197
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4197 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230821/dcb47fab/attachment-0001.htm>