[openstreetmap/openstreetmap-website] Don't limit blocks table width (PR #4199)

[Andy Allan]

Yes, this would definitely break with the existing site design! I also think that it's not a good result, from a design point of view.

Extra-wide content, even a table, becomes increasingly hard to read, so most designs have some kind of upper bound to the width. Usually the extra width on wide screens is used for additional columns, rather than making the central content column ever wider. My own screen is not particularly wide (1920px) but it becomes hard to e.g. look at both sides of the table, or move the mouse along one line to click the show button. 

There is also a strong argument that if something needs more than 960px for a single piece of content (e.g. a table with lots of columns) then it's going to need a more major redesign, in order to work on narrower screens too. Not everyone has extra-wide screens, particularly on mobile devices, so there needs to be some amount of responsive design to accommodate e.g. 960px wide screens anyway.

I can see the desire behind having a wider layout than 960px, but that desire should be to pick a larger width, and otherwise behave the same way as now (i.e. 100% up to a breakpoint, then fixed width), rather than just being completely unlimited.

Bootstrap has [containers](https://getbootstrap.com/docs/5.1/layout/containers/), which have similar breakpoints to our current custom css. We're using the equivalent width of `container-lg` for most pages, and something pretty close to `container-md` for other situations. So if I was to pick a bigger width, I would be looking at 1140px as the next size up.

It would be nice to ditch our custom css for layouts, and use bootstrap for this. It would take some experimentation though, since there's not a 1:1 mapping between our current behaviour and that of the bootstrap containers. We would need a class that says "up to the `container-md` breakpoint and no further", for example.

So in summary, I would decline this PR, and (if even necessary) approach this in a different manner. 

But I'm not yet convinced that any individual content panel should be over 960px anyway.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4199#issuecomment-1699255388
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4199/c1699255388 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230830/94828ee6/attachment.htm>