[openstreetmap/openstreetmap-website] Don't limit blocks table width (PR #4199)
Anton Khorev
notifications at github.com
Wed Aug 30 23:01:36 UTC 2023
Wide tables might be harder to read, but truncated content is impossible to read at all. *Reason for block* column can't have any meaningful amount of text in it. Now you see "Please contact OSM's Data W...", "Temporary account block - p..." or something like "Hello <username>, ...", but you already can see the username in another column. I wanted to use https://getbootstrap.com/docs/5.1/helpers/text-truncation/ in this column.
You can always make the browser window smaller, and get a narrower table. But you can't do the opposite thing. See also https://github.com/openstreetmap/openstreetmap-website/pull/1656#issuecomment-340909364
> or move the mouse along one line to click the show button
Does this table need *show* buttons? You can have a link from *Reason* to the block page. Maybe the *edit* and *revoke* buttons can also be removed and/or placed on individual block pages.
Maybe the username column can also be truncated.
> There is also a strong argument that if something needs more than 960px for a single piece of content (e.g. a table with lots of columns) then it's going to need a more major redesign, in order to work on narrower screens too.
Is it a statement about the existing design, which doesn't work well even with 960px in case there's a long username? What I want to add in #4200 doesn't require more space. Except for trying to make the *Reason* column to grow, but that is not included in #4200.
What if column are reordered and *Reason* is the last column and it grows to full browser window width, revealing more text? Would you still say that truncating it is better?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4199#issuecomment-1699963607
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4199/c1699963607 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230830/57745778/attachment-0001.htm>
More information about the rails-dev
mailing list