[openstreetmap/openstreetmap-website] Refactor notes to use resourceful routing (PR #3911)

[Andy Allan]

@gravitystorm commented on this pull request.



> @@ -2915,22 +2928,6 @@ en:
         unsubscribe: "Unsubscribe"
         hide_comment: "hide"
         unhide_comment: "unhide"
-    notes:
-      new:
-        intro: "Spotted a mistake or something missing? Let other mappers know so we can fix it. Move the marker to the correct position and type a note to explain the problem."
-        advice: "Your note is public and may be used to update the map, so don't enter personal information, or information from copyrighted maps or directory listings."
-        add: Add Note
-      show:
-        anonymous_warning: This note includes comments from anonymous users which should be independently verified.
-        hide: Hide
-        resolve: Resolve
-        reactivate: Reactivate
-        comment_and_resolve: Comment & Resolve

Great catch. I've added a system test that would have caught this.

I had a look to see what alternative approaches there are, to avoid having javascript determine the translated text, and to allow us to keep all content-related stuff in the erb view. I can see that Github uses data attributes for its own issue button ("Close issue" and "Close with Comment"), and uses javascript only to swap between them (rather than fetching one of the strings from elsewhere). So I've adopted the same pattern here.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3911#discussion_r1093527545
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3911/review/1279562375 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230201/49ffd0f2/attachment.htm>