[openstreetmap/openstreetmap-website] Remove Geonames and geocoder.ca (PR #3886)

[Richard Fairhurst]

As a historical legacy, we currently return search results from Geonames and geocoder.ca.

We did this in the early days of OSM as a convenience to help people navigate round the map - i.e. if Frogsbury hadn't been mapped yet, it was useful to be able to navigate to Frogsbury and start contributing there. Now that OSM's coverage is so much greater, there's no need for this any more. It's counter-intuitive to return non-OSM data when searching osm.org, and IMX Geonames usually returns "No results found" in any case.

This PR simply removes the support for Geonames and geocoder.ca. The only remaining geocoder engines are Nominatim (forward/reverse) and the simple latlon reader.

Ultimately this is a very small step towards replacing GeocoderController with client-side parsing of Nominatim responses, which would make them easier to use in other contexts (e.g. the placename search for routing), as per #80. #1881 also refers.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3886

-- Commit Summary --

  * Remove Geonames and geocoder.ca

-- File Changes --

    M app/abilities/ability.rb (3)
    M app/controllers/geocoder_controller.rb (98)
    M config/locales/en.yml (3)
    M config/routes.rb (3)
    M config/settings.yml (4)
    M config/settings/test.yml (2)
    M test/abilities/abilities_test.rb (4)
    M test/controllers/geocoder_controller_test.rb (83)
    D test/http/geocoder_ca.yml (54)
    D test/http/geonames.yml (228)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3886.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3886.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3886
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3886 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230109/07ce13e9/attachment.htm>