[openstreetmap/openstreetmap-website] Use bin/yarn consistently for installations (PR #3890)
Andy Allan
notifications at github.com
Wed Jan 11 15:05:29 UTC 2023
> It's not really our `bin/yarn` script... I'm pretty sure it came from rails and I just hacked it to add the switch and now rails has stopped using it.
I meant that it's ours now :smile: Yes, it came from upstream rails, but they've stopped creating it for new applications. In different circumstances we would be deleting it as no longer required.
> I'm kind of reluctant to switch away from upstream's documented way of doing things,
So am I, but I think the alternatives are worse.
* If we do `bundle exec rails yarn:install` then we need to require non-Ubuntu packaged yarn, and we need to require everyone installs Nodejs 16+ (for no good reason).
* If we do `yarn install --ignore-engines`, then we still need to explain that it's `yarnpkg install --ignore-engines` on Ubuntu, which is additional complexity.
* Alternatively we do `bundle exec bin/yarn install` as per this PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3890#issuecomment-1378897411
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3890/c1378897411 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230111/16028f4b/attachment.htm>
More information about the rails-dev
mailing list