[openstreetmap/openstreetmap-website] Replace page numbers with ID based selection for trace indexes (PR #4089)
Tom Hughes
notifications at github.com
Wed Jul 19 17:23:19 UTC 2023
@tomhughes commented on this pull request.
> @@ -8,51 +8,27 @@ def test_routes
{ :path => "/traces", :method => :get },
{ :controller => "traces", :action => "index" }
)
- assert_routing(
- { :path => "/traces/page/1", :method => :get },
- { :controller => "traces", :action => "index", :page => "1" }
- )
I'd love to test the redirects but I couldn't find a way to do so... I think I've been here before and failed to find a way to do it :-(
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4089#discussion_r1268396626
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4089/review/1537604187 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230719/94e7c6c3/attachment.htm>
More information about the rails-dev
mailing list