[openstreetmap/openstreetmap-website] Replace page numbers with ID based selection for trace indexes (PR #4089)
Tom Hughes
notifications at github.com
Wed Jul 19 17:24:13 UTC 2023
@tomhughes commented on this pull request.
> @@ -54,14 +54,16 @@ def index
@traces = @traces.tagged(params[:tag]) if params[:tag]
- @params = params.permit(:display_name, :tag)
+ @params = params.permit(:display_name, :tag, :min_id, :max_id)
I based `max_id` on what we were already doing doing for changesets in the history view but I wasn't especially keen on it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4089#discussion_r1268397498
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4089/review/1537605528 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230719/af153587/attachment.htm>
More information about the rails-dev
mailing list