[openstreetmap/openstreetmap-website] Replace page numbers with ID based selection for trace indexes (PR #4089)

Andy Allan notifications at github.com
Wed Jul 19 17:25:04 UTC 2023


@gravitystorm commented on this pull request.



> @@ -8,51 +8,27 @@ def test_routes
       { :path => "/traces", :method => :get },
       { :controller => "traces", :action => "index" }
     )
-    assert_routing(
-      { :path => "/traces/page/1", :method => :get },
-      { :controller => "traces", :action => "index", :page => "1" }
-    )

We use this approach elsewhere in controller tests:

```
visit foo
assert_redirected_to bar
```

Would that work for here?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4089#discussion_r1268398504
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4089/review/1537607008 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230719/8e075cb3/attachment.htm>


More information about the rails-dev mailing list