[openstreetmap/openstreetmap-website] issue:#3988 Updated common.scss (PR #3992)

[Andy Allan]

@Prathm-s thank you for your first pull request.

I think the share sidebar ends up quite cramped, but perhaps usable, just about:
![3988d1](https://github.com/openstreetmap/openstreetmap-website/assets/360803/f76e5d2d-0d26-4099-b222-bde75e44e50e)

It also changes the other sidebars, like the layers menu:
![3988c1](https://github.com/openstreetmap/openstreetmap-website/assets/360803/bea7c017-4629-49d6-b709-4a7dcbc67b4f)

But it breaks the query tool and the new note panels.
![3988a1](https://github.com/openstreetmap/openstreetmap-website/assets/360803/739cf2a3-ad5c-4f75-81eb-f0440524a14c)

![3988b1](https://github.com/openstreetmap/openstreetmap-website/assets/360803/5553bc45-2d42-47b8-91ea-2ad084da3abc)

Compare the above with the way that the note panel works currently:
![3988de](https://github.com/openstreetmap/openstreetmap-website/assets/360803/48f81407-8f9d-4ed1-926b-62b970ad2542)

So I'm going to decline this PR, since it breaks other functionality on the page. 

You are welcome to make another PR, in which case please consider:

* Please check that your changes don't break any of the other sidebar panels.
* Is it better to use the same over/below layout as the Query Tool and New Note panels? Or is side-by-side better?
* Please make a full commit message. We have some guidance in our [CONTRIBUTING.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#committing) file.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3992#issuecomment-1590877580
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3992/c1590877580 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230614/1cbf83b8/attachment-0001.htm>