[openstreetmap/openstreetmap-website] add IDs to note and changeset mail subjects (PR #3952)

Strubbl notifications at github.com
Wed Mar 1 21:52:48 UTC 2023


It would be very cool to have the note ID in the subject of emails, when a note was updated. This would also be helpful for changeset mails. I only did update the locale file for en, because i do not know where and how this needs also adjustments in the code to fill the ID place holders with the actual ID. This shall at least give an idea of i want to achieve.

At the moment the ID is only given indirectly via the noteurl or changeset_url in the user_mailer.rb. Is it anyhow easily possible to access the ID in the corresponding notification functions? Would it be ok for you to improve the mail subject to contain the ID?
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3952

-- Commit Summary --

  * add IDs to note and changeset mail subjects

-- File Changes --

    M config/locales/en.yml (8)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3952.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3952.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3952
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3952 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230301/c7a13f1f/attachment.htm>


More information about the rails-dev mailing list