[openstreetmap/openstreetmap-website] Add expansion of time info on touch and mouse activation (PR #4361)

Holger Jeromin notifications at github.com
Wed Nov 22 10:09:11 UTC 2023


> What's the purpose of setting the tabindex? Are there any side effects of that in terms of using keyboard navigation?

Without tabindex the action is not "sticky" so the expand is removed again with mouseup and touchend.

> In that picture it looks like there is a spurious space between the open parenthesis and the expanded date - if that's true can we get rid of it?

Yes, this is even encoded in the test (from #4349) if I understand the test:
`assert_match %r{^<time title=" *5 March 2014 at 18:58" datetime="2014-03-05T18:58:23Z">.*</time>$}, date`

It comes from `l(date, :format => :friendly)` where I have no idea which component implements this.
So this is IMO better tackled separately. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4361#issuecomment-1822467149
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4361/c1822467149 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231122/a63624f2/attachment-0001.htm>


More information about the rails-dev mailing list