[openstreetmap/openstreetmap-website] Use input group in search bar, but avoid positioning "where is this" in pixels (PR #4266)
Anton Khorev
notifications at github.com
Sun Oct 1 15:22:16 UTC 2023
https://github.com/openstreetmap/openstreetmap-website/pull/3690#issuecomment-1737780556
- color override problems are avoided by limiting the override to the direct button group child of the primary navigation ("edit", "history", "export" buttons)
- "where is this?" is turned into a button which makes is as tall as everything else in the search input group and "top: 6px;" is no longer required


You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4266
-- Commit Summary --
* Make search input a direct child of input group
* Write button instead of link for 'Where is this?'
* Limit nav color override to edit/history/export buttons
-- File Changes --
M app/assets/stylesheets/common.scss (9)
M app/views/layouts/_search.html.erb (12)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4266.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4266.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4266
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4266 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231001/7f47fff7/attachment.htm>
More information about the rails-dev
mailing list