[openstreetmap/openstreetmap-website] Account deletion cool-down period (PR #4313)

[Anton Khorev]

As I posted in the dwg chat:

- the delay is 1 day to make sure that there are no open changesets when users are deleted
- there's a setting, delays are disabled when set to 0
- I assumed that no possible law/regulation can exist that would require us to act faster than within a day
- no checks if the user is blocked, only the last changeset opening time
- I'd check the closing time, but there's no index together with uid

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4313

-- Commit Summary --

  * Add user account deletion delay test helper
  * Add earliest allowed deletion time to user model
  * Disable delete account button if there are recent changesets
  * Disallow account deletion after confirmation

-- File Changes --

    M app/controllers/account/deletions_controller.rb (4)
    M app/controllers/accounts_controller.rb (14)
    M app/helpers/application_helper.rb (4)
    M app/models/user.rb (8)
    M app/views/account/deletions/show.html.erb (10)
    M config/locales/en.yml (1)
    M config/settings.yml (2)
    A test/controllers/account/deletions_controller_test.rb (65)
    M test/controllers/accounts_controller_test.rb (19)
    M test/models/user_test.rb (38)
    M test/test_helper.rb (11)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4313.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4313.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4313
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4313 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231024/0a637da6/attachment-0001.htm>