[openstreetmap/openstreetmap-website] Mute hidden comment text in each table cell (PR #4230)

Anton Khorev notifications at github.com
Tue Sep 5 09:03:26 UTC 2023


How hidden comments in `/user/<username>/diary/comments` are displayed for those with permissions to see them:

Before:
![mute-comment-before](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/47d40d9b-5e4b-4ef4-8dd2-72da446f42fc)

After:
![mute-comment-after](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/9f195091-7f6d-4a1a-ad17-9124f6e9aec3)

This depends on Bootstrap's internal details of striped tables. I also wanted to change deleted comment backgrounds to a danger color like done elsewhere, but that depends on internal details even more (striped background is not really a background but a shadow and how its color is derived seems to have changed in later versions of Bootstrap).
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4230

-- Commit Summary --

  * Mute hidden comment text in each table cell

-- File Changes --

    M app/views/diary_entries/comments.html.erb (8)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4230.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4230.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4230
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4230 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230905/261f40bb/attachment-0001.htm>


More information about the rails-dev mailing list