[openstreetmap/openstreetmap-website] Don't use monospace font in single-line share inputs (PR #4235)
Anton Khorev
notifications at github.com
Thu Sep 7 10:26:06 UTC 2023
https://github.com/openstreetmap/openstreetmap-website/commit/dc24f6c2195c6053efd43778d53ae68984e54107#commitcomment-126688182
If you don't want custom font sizes even for things that are guaranteed not to fit on screen, maybe you don't want custom fonts as well? The buttons are not in a monospace font, why the inputs are, if they are supposed to be consistent with the buttons? You can argue that if an input has just a single-line url, monospace font is not required. Look at your browser's location bar. Does it have a monospace font? Probably no.
Before:

After:

The characters are not as wide, mote text fits on screen.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4235
-- Commit Summary --
* Don't use monospace font in single-line share inputs
-- File Changes --
M app/assets/javascripts/leaflet.share.js (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4235.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4235.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4235
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4235 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230907/f507b070/attachment.htm>
More information about the rails-dev
mailing list