[openstreetmap/openstreetmap-website] Don't use monospace font in single-line share inputs (PR #4235)
Andy Allan
notifications at github.com
Thu Sep 7 10:40:10 UTC 2023
I don't understand the motivation for this change. [A few minutes ago you posted a screenshot of the github url-copy widget](https://github.com/openstreetmap/openstreetmap-website/commit/dc24f6c2195c6053efd43778d53ae68984e54107#commitcomment-126693406), which I thought you were using as a good example. But it uses monospace for - and only for - the bit that shows the URL. So if that's a good example, then why this PR?
> If you don't want custom font sizes even for things that are guaranteed not to fit on screen, maybe you don't want custom fonts as well?
There's a difference between removing custom CSS (i.e. font sizes that were previously defined in custom.css), and using bootstrap rules for fonts. So your statement is a non-sequitur, since this PR isn't removing custom fonts - it's not touching anything in custom.css.
I think it would be better to focus on why this change should be made, i.e. what improvements it brings, instead.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4235#issuecomment-1709921905
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4235/c1709921905 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230907/4b6b750c/attachment-0001.htm>
More information about the rails-dev
mailing list