[openstreetmap/openstreetmap-website] Don't use monospace font in single-line share inputs (PR #4235)

Anton Khorev notifications at github.com
Thu Sep 7 11:04:18 UTC 2023


> But it uses monospace for - and only for - the bit that shows the URL. So if that's a good example, then why this PR?

Because I don't expect to convince you to decrease the font size you've just increased.

> There's a difference between removing custom CSS (i.e. font sizes that were previously defined in custom.css), and using bootstrap rules for fonts. So your statement is a non-sequitur, since this PR isn't removing custom fonts - it's not touching anything in custom.css.

You removed custom css AND changed font size. You could have done only one of these things instead. You are explaining that now it's better because the inputs are consistent with the buttons. But they aren't because they use different fonts.

> I think it would be better to focus on why this change should be made, i.e. what improvements it brings, instead.

Because the characters are not as wide, that's another way to fit more text.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4235#issuecomment-1709952564
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4235/c1709952564 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230907/b651c1af/attachment.htm>


More information about the rails-dev mailing list