[openstreetmap/openstreetmap-website] Remove usage of Sass division operator (PR #4247)

[Andy Allan]

This PR removes the remaining usage of the Sass division operator in our stylesheets.

https://sass-lang.com/documentation/breaking-changes/slash-div/

Whereever practicable, I've done this by refactoring the way that our styles work in order to remove the need for the custom css rules. In a few situations I took the "easy option" and converted the division to a multiplication instead, for the sake of time.

This work is a pre-requisite for moving to dartsass for compiling our stylesheets (the `sassc` gem, and the libsass project it uses, are both abandoned at this point, in favour of dartsass). And moving to dartsass (using `dartsass-sprockets`) is a prerequisite for us upgrading to newer versions of Bootstrap, which are incompatible with libsass.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4247

-- Commit Summary --

  * Remove unnecessary paragraph margin override on diary comments
  * Use multiplication for secondary-actions margin and padding
  * Use an inline list for the login auth buttons
  * Use spacer for margins on leaflet popups
  * Refactor the directions table to use bootstrap table styling
  * Remove custom styling from export alternative sources dl
  * Remove sass division for export input boxes margins
  * Remove unusual margins and line-height from comments
  * Refactor remaining sass division operators to use multiplication

-- File Changes --

    M app/assets/javascripts/index/directions.js (7)
    M app/assets/stylesheets/common.scss (52)
    M app/views/browse/changeset.html.erb (8)
    M app/views/notes/show.html.erb (4)
    M app/views/sessions/new.html.erb (22)
    M app/views/site/export.html.erb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4247.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4247.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4247
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4247 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230913/7c3c896b/attachment-0001.htm>