[openstreetmap/openstreetmap-website] List of user's changeset comments (PR #4248)

Anton Khorev notifications at github.com
Thu Sep 14 14:47:22 UTC 2023


Add user's changeset comments next to user's diary comments.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/903ad0a2-4af7-41b9-9cc4-88571fe8107e)

Pagination is reused along with traces list.
Localization strings are mostly kept in diary comments section for now.

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4248

-- Commit Summary --

  * Add blank 'comments for map edits' page
  * Show changeset comments table
  * Move common pagination code to mixin
  * Add changeset comments controller index test

-- File Changes --

    M app/abilities/ability.rb (2)
    M app/controllers/changeset_comments_controller.rb (19)
    A app/controllers/concerns/pagination_methods.rb (27)
    M app/controllers/diary_entries_controller.rb (21)
    M app/controllers/traces_controller.rb (16)
    M app/models/changeset_comment.rb (2)
    R app/views/changeset_comments/feed.rss.builder (0)
    A app/views/changeset_comments/index.html.erb (41)
    M app/views/diary_entries/comments.html.erb (13)
    M app/views/traces/index.html.erb (8)
    M config/locales/en.yml (12)
    M config/routes.rb (5)
    M test/controllers/changeset_comments_controller_test.rb (29)
    M test/controllers/diary_entries_controller_test.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4248.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4248.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4248
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4248 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230914/b1bc8e73/attachment.htm>


More information about the rails-dev mailing list