[openstreetmap/openstreetmap-website] List of user's changeset comments (PR #4248)

[Tom Hughes]

@tomhughes commented on this pull request.

I wonder if we should merge note comments under this interface eventually, and make the current user notes view just show notes they opened and not every comment - maybe as part of the planned restructuring of notes to make notes less linked to the initial comment.

> @@ -548,10 +550,12 @@ en:
         description: "Recent diary entries from users of OpenStreetMap"
     comments:
       title: "Diary Comments added by %{user}"
-      heading: "%{user}'s Diary Comments"
-      subheading_html: "Diary Comments added by %{user}"
-      no_comments: "No diary comments"
+      heading_html: "%{user}'s Comments"
+      for_diary: "For diary"
+      for_history: "For map edits"

I don't think the "For" prefix reads very well here and there's also inconsistent pluralisation between the two tabs. I think I would just go with `Diaries` or `Diary entries` for the first one and `Changesets` for the second - we could do `Map edits` but we already using changesets in other places so I think we should be consistent.

>    resources :notes, :path => "note", :only => [:show, :new]
 
   get "/user/:display_name/history" => "changesets#index"
   get "/user/:display_name/history/feed" => "changesets#feed", :defaults => { :format => :atom }
+  get "/user/:display_name/history/comments" => "changeset_comments#index", :as => :history_comments

I think we should use `changeset_comments` as the route name. I know that, for hysterical raisins, we use `history` in the URL but the controller is called `changeset_comments`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4248#pullrequestreview-1627320378
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4248/review/1627320378 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230914/c0b7b005/attachment.htm>