[openstreetmap/openstreetmap-website] Refactor element consistency checks (PR #4640)

Tom Hughes notifications at github.com
Mon Apr 1 17:42:18 UTC 2024


@tomhughes commented on this pull request.



> @@ -362,4 +362,86 @@ def test_containing_relations
     assert_equal relation_member2.relation.id, cr.second.id
     assert_equal relation_member3.relation.id, cr.third.id
   end
+
+  test "raises missing changeset exception when creating" do

We should really be consistent and stick to using `do test_` or else change all the existing test definitions but I see some using this style have already snuck in without being noticed so I guess a few more won't hurt :-(

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4640#pullrequestreview-1971786070
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4640/review/1971786070 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240401/d9ce0ebe/attachment.htm>


More information about the rails-dev mailing list