[openstreetmap/openstreetmap-website] Fix timeout on show note pages (PR #4647)

Anton Khorev notifications at github.com
Thu Apr 4 14:44:14 UTC 2024


Also disables timeout on index pages that show user's notes because:
- note timeouts never worked correctly
- no working non-map layout timeouts were implemented on the website

I might add index timeout later, but that wouldn't be fixing things, that would be implementing something new. 

Taken out of #4617 to keep that PR about fixing things that used to work.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4647

-- Commit Summary --

  * Timeout instantly if web_timeout setting is negative
  * Force map layout in web timeouts
  * Fix browse notes timeouts

-- File Changes --

    M app/controllers/application_controller.rb (14)
    M app/controllers/notes_controller.rb (2)
    A app/views/notes/timeout.html.erb (5)
    M config/locales/en.yml (2)
    M test/controllers/notes_controller_test.rb (11)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4647.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4647.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4647
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4647 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240404/555ec015/attachment.htm>


More information about the rails-dev mailing list