[openstreetmap/openstreetmap-website] Fix timeout messages for former browse pages (PR #4617)

Tom Hughes notifications at github.com
Thu Apr 4 16:58:13 UTC 2024


@tomhughes commented on this pull request.



> @@ -206,13 +206,13 @@ def web_timeout(&block)
     if e.is_a?(Timeout::Error) ||
        (e.is_a?(ActiveRecord::StatementInvalid) && e.message.include?("execution expired"))
       ActiveRecord::Base.connection.raw_connection.cancel
-      render :action => "timeout"
+      render "browse/timeout", :layout => map_layout

There are two controllers (changesets and changeset_comments) which have a timeout view already and with this change they will now render the browse timeout instead of their own one if they timeout? That was what I meant by breaking things that currently worked.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4617#discussion_r1552084041
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4617/review/1980594365 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240404/73924b0f/attachment.htm>


More information about the rails-dev mailing list