[openstreetmap/openstreetmap-website] Adapt notes table to dark mode by overriding Bootstrap colors (PR #4693)

Anton Khorev notifications at github.com
Sat Apr 13 01:22:29 UTC 2024


Alternative version of #4672 where we pretend that Bootstrap's `table-primary` supports dark mode.

`table-primary` is kept in the generated html. For notes table we only have to redefine a couple of colors in dark mode. In general this is not enough because there are variations for stripes, active colors etc but we're not using any of those here.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4693

-- Commit Summary --

  * Adapt notes table to dark mode by overriding Bootstrap colors

-- File Changes --

    M app/assets/stylesheets/common.scss (9)
    M app/views/notes/index.html.erb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4693.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4693.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4693
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4693 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240412/c2467e5f/attachment.htm>


More information about the rails-dev mailing list