[openstreetmap/openstreetmap-website] Adapt notes table to dark mode by overriding Bootstrap colors (PR #4693)

[Tobias]

@tordans commented on this pull request.

Visually, I like https://github.com/openstreetmap/openstreetmap-website/pull/4672 more. I also like more, that the changes are contained to the one view template and not split up into css+view. But then again, I am a big fan of utility class css like Tailwind…

If we go with this PR, I suggest to use the `sublte` term consistently and not overwrite "primary" with "primary-subtle".


> @@ -799,6 +799,15 @@ tr.turn:hover {
   }
 }
 
+/* Rules for notes pages */
+
+ at include color-mode(dark) {
+  .notes .table-primary td {

```suggestion
  .notes .table-primary-subtle td {
```

And in https://github.com/openstreetmap/openstreetmap-website/pull/4693/files#diff-4fe647349351c7492508c788230b91b7f4445d4b821f6781ac7fcfad5e879f21R27 also `table-primary-subtle`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4693#pullrequestreview-1999251971
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4693/review/1999251971 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240413/f9925b3d/attachment.htm>