[openstreetmap/openstreetmap-website] Adapt notes table to dark mode by overriding Bootstrap colors (PR #4695)

Anton Khorev notifications at github.com
Sat Apr 13 14:38:50 UTC 2024


Version 3 of #4672 and #4693 which slightly changes light mode colors but probably nobody is going to notice it.

`table-*` classes [happen to use "subtle" background colors](https://github.com/openstreetmap/openstreetmap-website/pull/4693#discussion_r1564038196) that look fine in light mode. They [don't adapt to dark mode](https://github.com/openstreetmap/openstreetmap-website/pull/4672#discussion_r1557742890) so we have to override them if we [still want to use them](https://github.com/openstreetmap/openstreetmap-website/pull/4669#issuecomment-2045718454). An obvious override is to set them to "subtle" colors in dark mode, that's what I tried in #4672 and it looks too dark. In this PR I'm doing the same thing I did in the legend abode the table and use the "non-subtle" color with 25% opacity.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/1283617a-6a24-4e5b-a311-14984fb520c6)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4695

-- Commit Summary --

  * Adapt notes table to dark mode by overriding Bootstrap colors

-- File Changes --

    M app/assets/stylesheets/common.scss (7)
    M app/views/notes/index.html.erb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4695.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4695.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4695
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4695 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240413/3412d470/attachment-0001.htm>


More information about the rails-dev mailing list