[openstreetmap/openstreetmap-website] Support dark mode in notes and tags tables (PR #4700)

Anton Khorev notifications at github.com
Sun Apr 14 14:59:17 UTC 2024


Assumptions:
- We're committed to style tables with `table-*` classes as if Bootstrap supports dark mode.
- Because Bootstrap actually doesn't support dark mode with `table-*` we want some isolated fix that's going to be removed once the support is there.  This fix is in the changes to `common.scss`.
- We don't want classes like `table-light` because we don't want table cells to stay light in dark mode. But this class was used in tags table for tag keys, so it has to be replaced with some other `table-*` class. It's replaced here with `table-secondary` although this makes tag key cells darker in light mode.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4700

-- Commit Summary --

  * Use body color in notes table legend
  * Use secondary color in tag key table column
  * Add dark mode overrides for Bootstrap table variants

-- File Changes --

    M app/assets/stylesheets/common.scss (15)
    M app/views/browse/_tag.html.erb (2)
    M app/views/notes/index.html.erb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4700.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4700.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4700
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4700 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240414/c715d0e8/attachment.htm>


More information about the rails-dev mailing list