[openstreetmap/openstreetmap-website] Pagination newest oldest split (PR #4729)

Anton Khorev notifications at github.com
Sat Apr 27 04:29:34 UTC 2024


#4710 + #4707 + all borders rounded. With this rounding the buttons won't be able to collapse into one block, there will always be a gap between "newer" and "older".

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/bc682324-44f8-435d-ae4d-cdb3794ffc22)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/4cbd2796-5530-44b3-be36-6b82e6f83b44)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/c297922b-26a2-4462-9d41-67f924984d30)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4729

-- Commit Summary --

  * Pass translation scope instead of keys to shared pagination
  * Introduce pagination item helper
  * Replace previous/next page selectors with helper methods in tests
  * Add oldest/newest links to shared pagination
  * Show only pagination icons below medium/small screen sizes
  * Move next/last page buttons to the right side

-- File Changes --

    A app/helpers/pagination_helper.rb (13)
    M app/views/diary_entries/comments.html.erb (3)
    M app/views/diary_entries/index.html.erb (3)
    M app/views/shared/_pagination.html.erb (44)
    M app/views/traces/index.html.erb (6)
    M app/views/user_blocks/_blocks.html.erb (3)
    M app/views/users/index.html.erb (6)
    M config/locales/en.yml (28)
    M test/controllers/diary_entries_controller_test.rb (45)
    M test/controllers/traces_controller_test.rb (76)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4729.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4729.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4729
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4729 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240426/a4f3c2eb/attachment.htm>


More information about the rails-dev mailing list