[openstreetmap/openstreetmap-website] Add oldest/newest links to shared pagination - with gaps around "newer" and "older" (PR #4733)

Anton Khorev notifications at github.com
Sun Apr 28 01:16:03 UTC 2024


Alternative split, see https://github.com/openstreetmap/openstreetmap-website/pull/4729#issuecomment-2081255352

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/cdc2471b-01fd-4053-8f37-239a3535d52b)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/fc25c4a9-e24a-4da7-8126-88ac9b6e00ba)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/041eb571-ecd7-40c9-974b-00080dd6903a)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4733

-- Commit Summary --

  * Pass translation scope instead of keys to shared pagination
  * Introduce pagination item helper
  * Replace previous/next page selectors with helper methods in tests
  * Add oldest/newest links to shared pagination
  * Show only pagination icons below medium/small screen sizes
  * Split pagination buttons into 3 groups

-- File Changes --

    A app/helpers/pagination_helper.rb (13)
    M app/views/diary_entries/comments.html.erb (3)
    M app/views/diary_entries/index.html.erb (3)
    M app/views/shared/_pagination.html.erb (46)
    M app/views/traces/index.html.erb (6)
    M app/views/user_blocks/_blocks.html.erb (3)
    M app/views/users/index.html.erb (6)
    M config/locales/en.yml (28)
    M test/controllers/diary_entries_controller_test.rb (45)
    M test/controllers/traces_controller_test.rb (76)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4733.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4733.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4733
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4733 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240427/03e22abd/attachment-0001.htm>


More information about the rails-dev mailing list