[openstreetmap/openstreetmap-website] Add oldest/newest links to shared pagination - with gaps around "newer" and "older" v2 (PR #4734)
Anton Khorev
notifications at github.com
Sun Apr 28 01:25:12 UTC 2024
#4733 without "oldest"/"newest" button text on any screen width and with `title` tooltips.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4734
-- Commit Summary --
* Pass translation scope instead of keys to shared pagination
* Introduce pagination item helper
* Replace previous/next page selectors with helper methods in tests
* Add oldest/newest links to shared pagination
* Show only pagination icons below medium/small screen sizes
* Split pagination buttons into 3 groups
* Add tooltips, make newest/oldest buttons tooltip only
-- File Changes --
A app/helpers/pagination_helper.rb (13)
M app/views/diary_entries/comments.html.erb (3)
M app/views/diary_entries/index.html.erb (3)
M app/views/shared/_pagination.html.erb (48)
M app/views/traces/index.html.erb (6)
M app/views/user_blocks/_blocks.html.erb (3)
M app/views/users/index.html.erb (6)
M config/locales/en.yml (28)
M test/controllers/diary_entries_controller_test.rb (45)
M test/controllers/traces_controller_test.rb (76)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4734.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4734.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4734
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4734 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240427/cdeccf6d/attachment.htm>
More information about the rails-dev
mailing list