[openstreetmap/openstreetmap-website] Add pagination to Issues page (PR #5057)
David Tsiklauri
notifications at github.com
Mon Aug 19 10:08:43 UTC 2024
@nertc commented on this pull request.
> @@ -39,6 +44,10 @@ def index
last_updated_by = params[:last_updated_by].to_s == "nil" ? nil : params[:last_updated_by].to_i
@issues = @issues.where(:updated_by => last_updated_by)
end
+
+ @issues, @newer_issues_id, @older_issues_id = get_page_items(@issues, :limit => @params[:limit])
+
+ render :partial => "page" if turbo_frame_request_id == "pagination" || turbo_frame_request_id == "search"
It was written to update only the list part of the page when the search button was clicked. But it may be out of scope of this PR (as it introduces new action other than pagination). I'll remove and it may be a separate PR when we will finish pagination functionality.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5057#discussion_r1721541563
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5057/review/2245144029 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240819/4acf1b3b/attachment.htm>
More information about the rails-dev
mailing list