[openstreetmap/openstreetmap-website] Add pagination to Issues page (PR #5057)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -39,6 +44,10 @@ def index
       last_updated_by = params[:last_updated_by].to_s == "nil" ? nil : params[:last_updated_by].to_i
       @issues = @issues.where(:updated_by => last_updated_by)
     end
+
+    @issues, @newer_issues_id, @older_issues_id = get_page_items(@issues, :limit => @params[:limit])
+
+    render :partial => "page" if turbo_frame_request_id == "pagination" || turbo_frame_request_id == "search"

Right, but you can do that by telling the search form to target the `pagination` frame, which is all that is actually being updated given that is what you render.

If you thought the search form needed to be updated as well then the above should be rendering a larger section for `search` but I don't think that does need to be updated does, only the results (which are in the `pagination` frame) need to be updated?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5057#discussion_r1721545815
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5057/review/2245151208 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240819/5f40aa85/attachment.htm>