[openstreetmap/openstreetmap-website] Communities - communities (PR #3717)

[Andy Allan]

@gravitystorm commented on this pull request.

I'm at a bit of a loss how to approach this review, since the diff is huge (1700+ additions). 

So we could do this in two ways - I can go through the details (e.g. `<label>` should only be used for forms, it shouldn't have custom CSS, the `<h1>` in communities#index uses lego translations etc) or we can tackle the big picture (e.g. renaming the existing Communities model/controller, whether we want Yet Another OSM Thing Called Communities, etc).

What would be more helpful? Or should I just send you a stream of feedback as I go?



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3717#pullrequestreview-2251493595
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3717/review/2251493595 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240821/97412f77/attachment.htm>