[openstreetmap/openstreetmap-website] Convert dashboard test into a system test (PR #5107)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> @@ -0,0 +1,27 @@
+require "application_system_test_case"
+
+class DashboardSystemTest < ApplicationSystemTestCase

We have test named after:
- a thing in singular
- a thing in plural
- an action as a noun
- an action as a verb

In the [guides](https://guides.rubyonrails.org/v7.1/testing.html#system-testing) they have system tests named after things in plural and model tests after things in singular. If we want to do the same, we'll have to rename, for example, `ConfirmationResendSystemTest` to `ConfirmationsTest`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5107#discussion_r1728664776
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5107/review/2256780826 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240823/ef402e85/attachment.htm>