[openstreetmap/openstreetmap-website] Convert dashboard test into a system test (PR #5107)
Tom Hughes
notifications at github.com
Thu Aug 22 19:49:24 UTC 2024
@tomhughes commented on this pull request.
> @@ -0,0 +1,27 @@
+require "application_system_test_case"
+
+class DashboardSystemTest < ApplicationSystemTestCase
I wonder if we're doing something wrong with our system test naming... Other non-model tests like controller tests always put controller in the name and can be consistent between class and file names.
I can't say I like having odd cases where they don't align, and there isn't even a clash here, but I guess there is precedent.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5107#discussion_r1727726132
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5107/review/2255522911 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240822/d6cb8d09/attachment.htm>
More information about the rails-dev
mailing list