[openstreetmap/openstreetmap-website] Move changeset comments feed to resourceful routes (PR #4587)
Andy Allan
notifications at github.com
Wed Aug 28 17:30:33 UTC 2024
I've spent some time considering your point about whether we are `:show`ing a feed, or `:index`ing a list of changeset comments. In doing so, I've realised that I think the module naming in this PR might be the wrong way round, i.e. `Feeds::ChangesetCommentsController` vs `ChangesetComments::FeedsController`.
But with everything related to `routes.rb`, the only way I can be sure is by messing around and seeing what happens, and now I have an alternative approach ready that I prefer, but I'm not sure what you will think of it.
So what I'm going to do is merge this PR, so that it unblocks your work, and then make my own followup PR for you to review.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4587#issuecomment-2315905389
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4587/c2315905389 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240828/6f91c908/attachment.htm>
More information about the rails-dev
mailing list