[openstreetmap/openstreetmap-website] Use map tiles dark mode with leaflet-osm plugin (PR #5396)

Tom Hughes notifications at github.com
Thu Dec 12 20:25:21 UTC 2024


@tomhughes requested changes on this pull request.

I don't think leaflet-osm should be getting involved in automatic transforms - it should have the ability to select a dark tile version where there is one and any automatic transformations should only be in the osm.org code.

>      options = L.Util.setOptions(this, options);
-    L.TileLayer.prototype.initialize.call(this, options.url);
+    url = isDarkMap ? options.darkUrl : options.lightUrl;

There is no `lightUrl` anywhere?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5396#pullrequestreview-2500710248
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5396/review/2500710248 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241212/f8f01d03/attachment.htm>


More information about the rails-dev mailing list