[openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)
Andy Allan
notifications at github.com
Tue Dec 17 20:38:36 UTC 2024
What's the source(s) of all the javascript in `vendor/`? I would expect to see `Vendorfile` updated, or preferably if these are sourced from e.g. node modules, then they should be included in package.json and added using the assets pipeline. If any of these are source files, i.e. written just for this project, then they should be in app/.
Also, how does the inclusion of popper interact with the popper already included? We end up with `//= require popper` twice in application.js.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2549573898
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5402/c2549573898 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241217/604484e8/attachment.htm>
More information about the rails-dev
mailing list