[openstreetmap/openstreetmap-website] Use map tiles dark mode without leaflet-osm plugin (PR #5397)
Tom Hughes
notifications at github.com
Wed Dec 18 12:40:17 UTC 2024
@tomhughes commented on this pull request.
This has gone rather further than I intended from my comments on #5396 by moving everything back into the web site code.
My thinking was the leaflet-osm would still have the `darkUrl` attribute on the layer, and probably an option to the constructor that would cause it to be used if available, and only if that wasn't possible would the web site code activate a filter instead.
The only thing I'm not sure about is how to signal back to this code whether dark more was possible.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5397#pullrequestreview-2511717176
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5397/review/2511717176 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241218/137029de/attachment.htm>
More information about the rails-dev
mailing list