[openstreetmap/openstreetmap-website] Use map tiles dark mode without leaflet-osm plugin (PR #5397)
Marwin Hochfelsner
notifications at github.com
Wed Dec 18 13:17:38 UTC 2024
@tomhughes This is also further than I anticipated it would go.
But I found it too hacky to overwrite the class's properties from the instance each time, and I especially wanted to avoid using `__proto__`. Yet I couldn't find a way to do that.
But then I stumbled upon #5386 and its new layer definition handler that allowed me to eliminate those hacks since this would specify the scheme on the instance creation.
Also not involving leaflet-osm at all would increase the flexibility with things like SVG filters, where I don't see an easy option to have that sourced from JS nicely.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5397#issuecomment-2551299817
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5397/c2551299817 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241218/95005110/attachment.htm>
More information about the rails-dev
mailing list