[openstreetmap/openstreetmap-website] Move code that runs after user save from save_new_user to create method (PR #5446)

[Anton Khorev]

Currently `save_new_user` does other things like redirects after the actual save. That obscures which pages are reachable from actions that call `save_new_user`, see https://github.com/openstreetmap/openstreetmap-website/issues/5431#issuecomment-2564561794.

Also `save_new_user` accesses referer in two different ways: as a function argument and as `params[:referer]`.

---

Added test for clicking *Sign Up*, filling out email-login-password, clicking *Sign Up*, opening confirmation link from email.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5446

-- Commit Summary --

  * Add within_content_body system test helper
  * Test signup with confirmation email
  * Move code that runs after user save from save_new_user to create method

-- File Changes --

    M app/controllers/users_controller.rb (40)
    M test/application_system_test_case.rb (4)
    M test/system/user_signup_test.rb (53)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5446.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5446.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5446
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5446 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241228/cfef4f23/attachment-0001.htm>