[openstreetmap/openstreetmap-website] Replace resent confirmation link with button (PR #5447)

[Anton Khorev]

Includes #5446

There's an issue that the *resend confirmation email* link reads "click here" #5431. I think there shouldn't be any link at all, this should be a button because it does something, not just loads a page. And the page shouldn't be accessible by GET, the button should trigger POST. When you accept the confirmation link, there's also a button which posts, but its hidden and autoclicked by javascript. The current resend link+GET existed since https://github.com/openstreetmap/openstreetmap-website/commit/bddf524c888c7364119a673e9b6c0518b0c6f93d.

Fixes #5431 by not having a link, and not writing "click here" on a button.

![image](https://github.com/user-attachments/assets/17ce59ea-fd7d-420c-bb35-91b09603074b)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5447

-- Commit Summary --

  * Add within_content_body system test helper
  * Test signup with confirmation email
  * Move code that runs after user save from save_new_user to create method
  * Replace resent confirmation link with button

-- File Changes --

    M app/controllers/users_controller.rb (40)
    M app/views/confirmations/confirm.html.erb (6)
    M config/locales/en.yml (4)
    M config/routes.rb (2)
    M test/application_system_test_case.rb (4)
    M test/controllers/confirmations_controller_test.rb (8)
    M test/system/user_signup_test.rb (88)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5447.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5447.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5447
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5447 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241228/3ce606e1/attachment.htm>